[Bug 740557] Feature: video_test_src_ball motion based on system clock

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=740557
  GStreamer | gst-plugins-base | git

Nicolas Dufresne (stormer) <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #291277|none                        |needs-work
             status|                            |

--- Comment #2 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> 2014-11-22 21:18:56 UTC ---
Review of attachment 291277:
 --> (https://bugzilla.gnome.org/review?bug=740557&attachment=291277)

I'm not sure it's such a great idea to change an existing test effect. Creating
new one would be better from my point of view. The second thing is that this is
test patterns, most of them are taken from standards or are designed to test
specific things. They are not designed to please human eye. What are you
testing with this ?

::: gst/videotestsrc/videotestsrc.c
@@ +1073,3 @@
+  struct timeval tv;
+
+  gettimeofday (&tv, NULL);

First, gettimeofday() should never be used for animation on a computer. Think
of what will hapen if you switch timezone, or the jittery cause by NTP deamon
adjusting the clock.

Second, in GStreamer we use GStreamer clock, in this case I think time
information is already in GstVideoFrame somewhere.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.