[Bug 740694] decodebin2: Take STREAM_LOCK before sending sticky events.

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=740694
  GStreamer | gst-plugins-base | unspecified

Thibault Saunier <tsaunier> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #291474|0                           |1
        is obsolete|                            |

--- Comment #4 from Thibault Saunier <tsaunier at gnome.org> 2014-11-25 17:19:46 UTC ---
Created an attachment (id=291480)
 View: https://bugzilla.gnome.org/attachment.cgi?id=291480
 Review: https://bugzilla.gnome.org/review?bug=740694&attachment=291480

decodebin2: Take STREAM_LOCK before sending sticky events.

There was a race where:

1) we would put the element to PAUSED
2) It would get data sent to it from upstream
3) It would thus send caps
3) caps_notify_cb would continue autoplugging
4) caps would flow downstream, the last pad would get exposed
5) we were still not done sending the sticky events

Taking the stream lock on the new element's sinkpad and only
releasing it when sticky events have all been sent prevents
the caps from reaching the source pad of the element before
we're all set.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.