[Bug 740236] New interleave2 based on GstAggregator and create GstAudioAggregator from audiomixer

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=740236
  GStreamer | gst-plugins-bad | git

--- Comment #34 from Thibault Saunier <tsaunier at gnome.org> 2014-11-25 21:54:44 UTC ---
> Open questions:
> - We should probably rename GstAudioAggregator and GstVideoAggregator into
> GstRaw...Aggregator as they only handle raw and raw-like formats.

I do not expect to have any subclass working handling encoded audio/video soon,
I would just keep it short and make it a GstEncodedVideoAggregator in the case
it is needed at some point. 

> - The various members of GstAggregator have unclear locking rules, in
> particular, it's not clear what the rules are for the "segment" member.

I will go over them and document that, it is indeed clearly missing
documentation, and now I am not sure how segment is supposed to be protected.

> - I'm unhappy about how the "unresponsive" pads are handled (but I made that
> argument on bug #739010 already)
> - The .._set_src_pad() delaying should probably happen in the base class (which
> should handle the mecanism of bufferpool and allocator negotiation), this would
> make it easier for GstAudioAggregator to use a downstream GstAllocator if
> possible (for example, when using shmsink).

That would be a nice feature to add indeed :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.