[Bug 727464] ORC does not preserve NEON/VFP registers according to ARM PCS

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=727464
  GStreamer | orc | unspecified

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #289408|none                        |reviewed
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-11-26 11:27:56 UTC ---
Review of attachment 289408:
 --> (https://bugzilla.gnome.org/review?bug=727464&attachment=289408)

::: orc/orcarm.c
@@ +99,3 @@
+    ORC_ASM_CODE(compiler,"}\n");
+
+    orc_arm_emit (compiler, 0xe92d0000 | regs);

Previously this still emitted this even if regs==0. Does this make any
functional difference?

::: orc/orcprogram-neon.c
@@ +55,3 @@
+  }
+
+  if (regs || vregs) orc_arm_emit_push (compiler, regs, vregs);

This check shouldn't be needed as you already do that inside push()

@@ +98,3 @@
+  }
+
+  if (regs) orc_arm_emit_pop (compiler, regs, vregs);

And here, also this check seems wrong and should be (regs || vregs) too AFAIU?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.