[Bug 740683] rtspsrc: add retransmission handling for rtp

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=740683
  GStreamer | gst-plugins-good | git

--- Comment #2 from Olivier Crête <olivier.crete at ocrete.ca> 2014-11-26 21:57:41 UTC ---
Review of attachment 291452:
 --> (https://bugzilla.gnome.org/review?bug=740683&attachment=291452)

Good job, I've been wanting this for a while! I wonder if we can set the
retranmission delay on rtpjitterbuffer based on the rtx-time in the SDP, I
couldn't find anything obvious.

::: gst/rtsp/gstrtspsrc.c
@@ +198,3 @@
 #define DEFAULT_TLS_VALIDATION_FLAGS     G_TLS_CERTIFICATE_VALIDATE_ALL
 #define DEFAULT_TLS_DATABASE     NULL
+#define DEFAULT_DO_RETRANSMISSION        FALSE

Any reason to default to false?

@@ +3170,3 @@
+  if (g_signal_lookup ("request-aux-receiver",
+          G_OBJECT_TYPE (src->manager)) == 0)
+    return;

rtspsrc and rtpbin are both in gst-plugins-good, we don't support mixing
different parts of different versions of the same package.

@@ +3209,3 @@
+  g_object_set (src->manager, "do-retransmission", TRUE, NULL);
+
+  /* enable RFC4588 retransmission handling by setting rtprtxreceive

Would it make sense to skip this if there are no RTX payloads in the SDP ? (and
skip the connect too)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.