[Bug 735665] gst-validate should concatenate its issue reporting in some cases.

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=735665
  GStreamer | gst-devtools | git

Thibault Saunier <tsaunier> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #287555|none                        |needs-work
             status|                            |

--- Comment #14 from Thibault Saunier <tsaunier at gnome.org> 2014-10-02 06:59:50 UTC ---
Review of attachment 287555:
 --> (https://bugzilla.gnome.org/review?bug=735665&attachment=287555)

::: validate/gst/validate/gst-validate-report.c
@@ -493,2 +493,3 @@
 gst_validate_report_unref (GstValidateReport * report)
 {
+  if (report == NULL)

Should be g_return_if_fail, nowhere in APIs NULL is tolerated in refing funcs

@@ -502,2 +505,3 @@
 gst_validate_report_ref (GstValidateReport * report)
 {
+  if (report == NULL)

Same here

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.