[Bug 737735] wavenc writes broken file if caps are set

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=737735
  GStreamer | gst-plugins-good | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |slomo at coaxion.net
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |1.5.1

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-10-02 07:15:42 UTC ---
Each of these fixes it individually, but they're actually two separate bugs.

commit 798cafa7fc2716478d4e3bbcdfd2c89340c7ecc5
Author: Sebastian Dröge <sebastian at centricular.com>
Date:   Thu Oct 2 10:13:28 2014 +0300

    capsfilter: Push pending events before a buffer also if upstream never
configured caps but we have srcpad caps already

    Otherwise we never send pending events downstream that arrive after we
    configured caps on the srcpad.

    https://bugzilla.gnome.org/show_bug.cgi?id=737735

commit 7729f4ce81580df72e03e509966651eebb092d81
Author: Sebastian Dröge <sebastian at centricular.com>
Date:   Thu Oct 2 10:10:11 2014 +0300

    wavenc: Send CAPS event after the pad was activated

    Otherwise the CAPS event will be dropped and we never configure any caps at
    all, leading to weird behaviour in many situations. Especially header
    rewriting is not going to work if a capsfilter is after wavenc.

    https://bugzilla.gnome.org/show_bug.cgi?id=737735

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.