[Bug 736138] validate: Use information from the media_info file to test more deeply the execution of pipeline

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=736138
  GStreamer | gst-devtools | git

Mathieu Duponchelle <mathieu.duponchelle> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #287605|none                        |reviewed
             status|                            |

--- Comment #22 from Mathieu Duponchelle <mathieu.duponchelle at epitech.eu> 2014-10-03 00:59:14 UTC ---
Review of attachment 287605:
 --> (https://bugzilla.gnome.org/review?bug=736138&attachment=287605)

That's a very nice feature, and an even nicer test \o/

::: validate/gst/validate/gst-validate-pad-monitor.c
@@ +1295,3 @@
+      pad_monitor->check_buffers = FALSE;
+    } else if (!pad_monitor->caps_is_video) {
+      GST_DEBUG_OBJECT (pad, "Not working with video => no buffer checking");

*Only* working with video right ?

@@ +1591,3 @@
+
+  if (pad_monitor->current_buf == NULL) {
+    GST_INFO_OBJECT (pad, "No current buffer one pad, Why?");

on*

::: validate/gst/validate/gst-validate-pad-monitor.h
@@ +114,3 @@
+
+  /* GstMediaCheck related fields */
+  GList *all_bufs;

Why not a GSequence ? You could iterate inside it as well.

::: validate/gst/validate/gst-validate-report.h
@@ +78,3 @@
 #define GST_VALIDATE_ISSUE_ID_WRONG_FLOW_RETURN                       
(((GstValidateIssueId) GST_VALIDATE_AREA_BUFFER) << GST_VALIDATE_ISSUE_ID_SHIFT
| 5)
 #define GST_VALIDATE_ISSUE_ID_BUFFER_AFTER_EOS                        
(((GstValidateIssueId) GST_VALIDATE_AREA_BUFFER) << GST_VALIDATE_ISSUE_ID_SHIFT
| 6)
+#define GST_VALIDATE_ISSUE_ID_WRONG_BUFFER                            
(((GstValidateIssueId) GST_VALIDATE_AREA_BUFFER) << GST_VALIDATE_ISSUE_ID_SHIFT
| 7)

So sexy :P

::: validate/tests/check/validate/padmonitor.c
@@ +382,3 @@
+/* *INDENT-OFF* */
+static const gchar * media_info =
+"<file duration='10031000000' frame-detection='1'
uri='file:///I/am/so/fake.fakery' seekable='true'>"

seems legit

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.