[Bug 736138] validate: Use information from the media_info file to test more deeply the execution of pipeline

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=736138
  GStreamer | gst-devtools | git

--- Comment #30 from Thibault Saunier <tsaunier at gnome.org> 2014-10-03 08:08:47 UTC ---
Review of attachment 287605:
 --> (https://bugzilla.gnome.org/review?bug=736138&attachment=287605)

::: validate/gst/validate/gst-validate-pad-monitor.c
@@ +1295,3 @@
+      pad_monitor->check_buffers = FALSE;
+    } else if (!pad_monitor->caps_is_video) {
+      GST_DEBUG_OBJECT (pad, "Not working with video => no buffer checking");

Indeed.

@@ +1591,3 @@
+
+  if (pad_monitor->current_buf == NULL) {
+    GST_INFO_OBJECT (pad, "No current buffer one pad, Why?");

FIXED

::: validate/gst/validate/gst-validate-pad-monitor.h
@@ +114,3 @@
+
+  /* GstMediaCheck related fields */
+  GList *all_bufs;

I do not think it is critical here, the only moment where we will need to
iterate the list is when we get a new segment. It could be an optimization in
the future if we figure that it is needed.

::: validate/tests/check/validate/padmonitor.c
@@ +382,3 @@
+/* *INDENT-OFF* */
+static const gchar * media_info =
+"<file duration='10031000000' frame-detection='1'
uri='file:///I/am/so/fake.fakery' seekable='true'>"

Fakely legit, for sure!

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.