[Bug 737683] fakesrc: the "pattern" property can be gotten but it is never set or used

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=737683
  GStreamer | gstreamer (core) | 1.4.3

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #287648|none                        |accepted-commit_now
             status|                            |

--- Comment #12 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2014-10-03 09:09:15 UTC ---
(From update of attachment 287648)
Looks mostly fine, but:

>+    case PROP_PATTERN:
>+      g_value_set_string (value, src->pattern);
>+      break;

Don't need the set_string here, since the pattern wasn't set anyway, just make
it a break. The only thing we want to avoid is that people who have been using
this property without realising that it doesn't work now don't get nasty
criticals.

>diff --git a/plugins/elements/gstfakesrc.h b/plugins/elements/gstfakesrc.h
>index 5190ee8..e4acb9c 100644
>--- a/plugins/elements/gstfakesrc.h
>+++ b/plugins/elements/gstfakesrc.h
>@@ -134,6 +134,7 @@ struct _GstFakeSrc {
>   guint		parentsize;
>   guint		parentoffset;
>   guint8	 pattern_byte;
>+  gchar		*pattern;

Not needed any more then.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.