[Bug 737928] New: dcaparse: should be more strict about frame header parsing

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=737928
  GStreamer | gst-plugins-good | git

           Summary: dcaparse: should be more strict about frame header
                    parsing
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: matej.knopp at gmail.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Created an attachment (id=287760)
 --> (https://bugzilla.gnome.org/attachment.cgi?id=287760)
Patch

If frame header contains invalid channel configuration
gst_dca_parse_parse_header accepts such frame and returns 0 channel count.
That's outside of caps range (channels = (int) [ 1, 8 ]) and it doesn't really
make sense for downstream. 

I think such frame should probably be ignored.

Also, it would be nice to have header crc check :) Although  it wouldn't help 
with this particular file as there is no crc present.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.