[Bug 735627] wavenc/wavparse: should support RF64 files

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=735627
  GStreamer | gst-plugins-good | 1.4.0

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #287711|none                        |needs-work
             status|                            |

--- Comment #16 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-10-05 18:56:20 UTC ---
Review of attachment 287711:
 --> (https://bugzilla.gnome.org/review?bug=735627&attachment=287711)

::: gst/wavenc/gstwavenc.c
@@ +99,3 @@
+#define SRC_CAPS \
+    "audio/x-wav; " \
+    "audio/x-rf64"

Is audio/x-rf64 used by anything else already? As a mimetype maybe? Otherwise
an option would also be to use audio/x-wav,format=rf64

@@ +1033,3 @@
+      caps = gst_caps_truncate (caps);
+    }
+    str = gst_caps_to_string (caps);

GstStructure *s = gst_caps_get_structure (caps, 0);
wavenc->use_rf64 = gst_structure_has_name (s, "audio/x-rf64");

@@ +1037,3 @@
+    g_free (str);
+
+    gst_pad_set_caps (wavenc->srcpad, caps);

gst_caps_unref(caps)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.