[Bug 735195] bus: Missing API to remove a bus watch

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=735195
  GStreamer | gstreamer (core) | git

Nicolas Dufresne (stormer) <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nicolas.dufresne at collabora.
                   |                            |co.uk

--- Comment #16 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> 2014-10-05 20:08:42 UTC ---
(In reply to comment #0)
> When adding a bus watch, using gst_bus_add_watch(), to a non default main
> context, there are no API to remove this watch. The only reference to this
> watch is it's id returned by g_source_attach(). With an id it's only possible
> to remove sources from the default main context.

Just a correction:

tmc = g_main_context_get_thread_default ();
source = g_main_context_find_source_by_id (sid);
g_source_unref (source);

> 
> I think an API should be exposed to make it possible to use the feature of
> adding watches to something that is not the default main context, using
> gst_bus_add_watch(). Or remove that possiblity.

I do think that GLib API isn't very friendly with custom thread context. Still,
I'm myself in favour of adding a friendlier API.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.