[Bug 737999] systemclock: multi-thread entry status issue

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon Oct 6 05:41:14 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=737999
  GStreamer | gstreamer (core) | 1.4.3

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #287845|none                        |reviewed
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-10-06 12:41:12 UTC ---
Review of attachment 287845:
 --> (https://bugzilla.gnome.org/review?bug=737999&attachment=287845)

::: gst/gstsystemclock.c
@@ -739,3 @@
           /* timeout, this is fine, we can report success now */
-          status = GST_CLOCK_OK;
-          SET_ENTRY_STATUS (entry, status);

You're not setting the status at all anymore

@@ -768,3 @@
-      status = GST_CLOCK_EARLY;
-
-    SET_ENTRY_STATUS (entry, status);

And here

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list