[Bug 728353] goom2k1: code does nothing, slowly
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Mon Oct 6 06:31:47 PDT 2014
https://bugzilla.gnome.org/show_bug.cgi?id=728353
GStreamer | gst-plugins-good | git
--- Comment #4 from Luis de Bethencourt <luis.bg at samsung.com> 2014-10-06 13:31:42 UTC ---
Created an attachment (id=287852)
View: https://bugzilla.gnome.org/attachment.cgi?id=287852
Review: https://bugzilla.gnome.org/review?bug=728353&attachment=287852
Remove the block of code that does nothing
I have followed the flow of code and executed it extensively. This block of
code does nothing.
decc and spdc are initialized to zero.
decc is added the value of spdc / 10, which is zero. so decc is zero.
value of decc is stored in zf->firedec[].
decc is not bigger than 4 or smaller than -4, if blocks don't run.
same thing with spdc and bigger than 30 or smaller than -30.
again, decc checked for > 8 or < -8, nothing happens.
accel gets a random value and never used.
loop runs again.
I propose we remove this block of unneeded code.
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
More information about the gstreamer-bugs
mailing list