[Bug 738102] v4l2bufferpool: cleanly handle streamon failure for output device

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Tue Oct 7 10:12:49 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=738102
  GStreamer | gst-plugins-good | git

Nicolas Dufresne (stormer) <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #287979|none                        |needs-work
             status|                            |

--- Comment #3 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> 2014-10-07 17:12:45 UTC ---
Review of attachment 287979:
 --> (https://bugzilla.gnome.org/review?bug=738102&attachment=287979)

That is not supposed to be useful, finalize is calle once, but! Unrefing object
is suppose to happen in dispose() call, not finalize(), and in this case can be
called multiple time. The proper fix is to also implement dispose, and anything
that is object shall be unref and set to NULL there.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list