[Bug 738223] fluiddec: leaks memory in gst_fluid_dec_change_state()

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=738223
  GStreamer | gst-plugins-bad | unspecified

--- Comment #1 from Antonio Ospite <ao2 at ao2.it> 2014-10-09 11:55:07 UTC ---
Created an attachment (id=288114)
 View: https://bugzilla.gnome.org/attachment.cgi?id=288114
 Review: https://bugzilla.gnome.org/review?bug=738223&attachment=288114

fix memory leaks in fluiddec

The attached patch fixes the leaks in fluiddec, they are actually in
gst_fluid_dec_open().

I am also squeezing in a small documentation fix to midiparse as a separate
commit.

After this patch two leaks with the pipeline above are still present.

One in is the fluidsynth library itself and it has been fixed upstream already
http://sourceforge.net/p/fluidsynth/tickets/132/ so no need to worry.

Another one seems to be in GStreamer itself, maybe in some cases some events
are not unreffed? Should I report this in a separate issue?

==10070== 
==10070== 208 (32 direct, 176 indirect) bytes in 1 blocks are definitely lost
in loss record 1,760 of 1,826
==10070==    at 0x4C28C20: malloc (vg_replace_malloc.c:296)
==10070==    by 0x53E87C9: g_malloc (in
/lib/x86_64-linux-gnu/libglib-2.0.so.0.4200.0)
==10070==    by 0x53FF70F: g_slice_alloc (in
/lib/x86_64-linux-gnu/libglib-2.0.so.0.4200.0)
==10070==    by 0x4EBC762: gst_structure_new_id_empty_with_size (in
/usr/lib/x86_64-linux-gnu/libgstreamer-1.0.so.0.403.0)
==10070==    by 0x4EBEEAE: gst_structure_new_id (in
/usr/lib/x86_64-linux-gnu/libgstreamer-1.0.so.0.403.0)
==10070==    by 0x4E8A1F7: gst_event_new_caps (in
/usr/lib/x86_64-linux-gnu/libgstreamer-1.0.so.0.403.0)
==10070==    by 0x749F3C0: gst_midi_parse_loop (in
/usr/lib/x86_64-linux-gnu/gstreamer-1.0/libgstmidi.so)
==10070==    by 0x4EC9A15: gst_task_func (in
/usr/lib/x86_64-linux-gnu/libgstreamer-1.0.so.0.403.0)
==10070==    by 0x540A2B7: g_thread_pool_thread_proxy (in
/lib/x86_64-linux-gnu/libglib-2.0.so.0.4200.0)
==10070==    by 0x5409924: g_thread_proxy (in
/lib/x86_64-linux-gnu/libglib-2.0.so.0.4200.0)
==10070==    by 0x56B00A3: start_thread (pthread_create.c:309)

Thanks,
   Antonio

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.