[Bug 738102] v4l2bufferpool: cleanly handle streamon failure for output device

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=738102
  GStreamer | gst-plugins-good | git

Nicolas Dufresne (stormer) <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #288036|none                        |needs-work
             status|                            |

--- Comment #7 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> 2014-10-09 15:10:21 UTC ---
Review of attachment 288036:
 --> (https://bugzilla.gnome.org/review?bug=738102&attachment=288036)

::: sys/v4l2/gstv4l2bufferpool.c
@@ +1356,2 @@
   /* FIXME Is this required to keep around ? */
   gst_object_unref (pool->obj->element);

You forgot that one, specially that this one is a circular ref.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.