[Bug 736071] audiobasesink: Don't hold object lock while calling into other objects like the clock

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Fri Oct 10 02:48:37 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=736071
  GStreamer | gst-plugins-good | 1.2.1

Arun Raghavan <arun> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |

--- Comment #12 from Arun Raghavan <arun at accosted.net> 2014-10-10 09:48:35 UTC ---
Okay, so it is not possible to emit this message within the PulseAudio thread
context while maintaining locking order (GST_OBJECT_LOCK before
pa_threaded_mainloop_lock).

This being the case, I see the following alternatives:

1. Create the message in the PA mainloop thread (since we need the thread id),
but emit the enter/leave status messages from another thread (without the
mainloop lock held)

2. Stop emitting the enter/leave status messages altogether

I'm leaning towards (1) unless someone sees a reason not to (the only thing I
can think of is that there might be synchronous listeners of the stream status
message that hope to be called in the audio mainloop thread context, but it's
possible that this is not meaningful).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list