[Bug 738069] waylandsink: avoid render twice the same buffer

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Sat Oct 11 08:40:46 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=738069
  GStreamer | gst-plugins-bad | 1.4.3

George Kiagiadakis <george.kiagiadakis> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |george.kiagiadakis at collabor
                   |                            |a.com
         Resolution|                            |FIXED

--- Comment #6 from George Kiagiadakis <george.kiagiadakis at collabora.com> 2014-10-11 15:40:43 UTC ---
I think it makes sense to work it around in waylandsink, so I have committed
it. I knew about this bug and I meant to fix it myself, I just gave it very low
priority because it was harmless.

commit 23bb5f53196773139e138a67a4ed2ee2dedc9aa9
Author: Benjamin Gaignard <benjamin.gaignard at linaro.org>
Date:   Tue Oct 7 10:37:33 2014 +0200

    waylandsink: do not render twice the same buffer

    Do not try to render a buffer that is already being rendered.
    This happens typically during the initial rendering stage as the first
    buffer is rendered twice: first by preroll(), then by render().
    This commit avoids this assertion failure:
      CRITICAL: gst_wayland_compositor_acquire_buffer: assertion
      'meta->used_by_compositor == FALSE' failed

    https://bugzilla.gnome.org/show_bug.cgi?id=738069

    Signed-off-by: Fabien Dessenne <fabien.dessenne at st.com>
    Signed-off-by: Benjamin Gaignard <benjamin.gaignard at linaro.org>

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list