[Bug 738124] validate: Design and implement an interface for setting a report level.

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Sun Oct 12 13:32:02 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=738124
  GStreamer | gst-devtools | git

Thibault Saunier <tsaunier> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #288317|none                        |needs-work
             status|                            |

--- Comment #23 from Thibault Saunier <tsaunier at gnome.org> 2014-10-12 20:31:56 UTC ---
Review of attachment 288317:
 --> (https://bugzilla.gnome.org/review?bug=738124&attachment=288317)

::: validate/tests/check/validate/padmonitor.c
@@ +35,3 @@
+
+  for (tmp = reports; tmp; tmp = tmp->next) {
+    if (((GstValidateReport *) tmp->data)->refcount != refcount)

You should rather fail_unless_equals_int here, makes it simpler to debug.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list