[Bug 738124] validate: Design and implement an interface for setting a report level.

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=738124
  GStreamer | gst-devtools | git

Thibault Saunier <tsaunier> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #288321|none                        |reviewed
             status|                            |

--- Comment #33 from Thibault Saunier <tsaunier at gnome.org> 2014-10-13 15:17:56 UTC ---
Review of attachment 288321:
 --> (https://bugzilla.gnome.org/review?bug=738124&attachment=288321)

::: validate/tests/check/validate/reporting.c
@@ +129,3 @@
+static void
+_create_issues (GstValidateRunner * runner)
+{

Can't you just create reports yourself in the tests? Simply doing

GST_VALIDATE_REPORT("Some report") where you want?

I looks a bit overkill to actually create pipeline + adding probes etc etc...
to just test reporting filtering.

@@ +167,3 @@
+  segment.stop = GST_SECOND;
+
+  fail_unless (gst_pad_push_event (srcpad1,

gst_check_setup_events ?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.