[Bug 738124] validate: Design and implement an interface for setting a report level.

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=738124
  GStreamer | gst-devtools | git

Thibault Saunier <tsaunier> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #288323|none                        |reviewed
             status|                            |

--- Comment #35 from Thibault Saunier <tsaunier at gnome.org> 2014-10-13 15:27:21 UTC ---
Review of attachment 288323:
 --> (https://bugzilla.gnome.org/review?bug=738124&attachment=288323)

::: validate/gst/validate/gst-validate-runner.c
@@ +320,3 @@
+
+  issue_id = report->issue->issue_id;
+  reports =

You need the lock even to retrieve the reoprts here

@@ +376,3 @@
   GST_VALIDATE_RUNNER_LOCK (runner);
   l = g_list_length (runner->priv->reports);
+  l += g_hash_table_size (runner->priv->reports_by_type);

How is that?

::: validate/tests/check/validate/padmonitor.c
@@ -39,3 +41,3 @@
   }

-  g_list_free_full (reports, (GDestroyNotify )gst_validate_report_unref);
+  g_list_free_full (reports, (GDestroyNotify) gst_validate_report_unref);

There are many changes like that I can not parse in that file, you bought a
gst-indent? :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.