[Bug 738124] validate: Design and implement an interface for setting a report level.

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=738124
  GStreamer | gst-devtools | git

Thibault Saunier <tsaunier> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #288330|none                        |reviewed
             status|                            |

--- Comment #42 from Thibault Saunier <tsaunier at gnome.org> 2014-10-13 15:35:59 UTC ---
Review of attachment 288330:
 --> (https://bugzilla.gnome.org/review?bug=738124&attachment=288330)

::: validate/gst/validate/gst-validate-reporter.c
@@ +177,3 @@
+        GST_VALIDATE_REPORTING_LEVEL_UNKNOWN;
+
+    if (priv->runner)

runners are mandatory

::: validate/tests/check/validate/reporting.c
@@ +289,3 @@
+  runner = gst_validate_runner_new ();
+  _create_issues (runner);
+  /* 2 issues repeated on the fakesink's sink */

Why don't you check the details here then? :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.