[Bug 738319] rtpsession: fix Early Feedback Transmission

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=738319
  GStreamer | gst-plugins-good | 1.4.1

--- Comment #3 from Miguel París Díaz <mparisdiaz at gmail.com> 2014-10-13 15:36:21 UTC ---
Hello,
we have compared the GStreamer implementation (rtpsession.c) with the RFC 
http://tools.ietf.org/html/rfc4585#section-3.5.2 and we have noticed that steps
4a.2 and 6 were missed, which are very important for the correct behaviour.

I upload a new patch where I have tried to change as less as possible.
The solution that I propose is that rtp_session_send_rtcp() function returns
TRUE if the related RTCP can be scheduled
Then it is called before registering NACKs or PLIs/FIRs, and if it returns
FALSE, the RTCP is discarded.

By the moment, I do not use rtcp_immediate_feedback_threshold, but we can see
how it must be used following the RFC.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.