[Bug 734098] gst_element_set_state blocked when plugout a usb audio device

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=734098
  GStreamer | gst-plugins-good | 1.x

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #288210|none                        |needs-work
             status|                            |

--- Comment #14 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-10-14 08:19:26 UTC ---
Review of attachment 288210:
 --> (https://bugzilla.gnome.org/review?bug=734098&attachment=288210)

If you update the patch, please attach it in "git format-patch" format with a
proper commit message, and the name/mail details set up in GIT :)

In general looks good, just some minor comments. Thanks for the patch!

::: gstdirectsoundsink.c
@@ +541,3 @@
   GstDirectSoundSink *dsoundsink;
   DWORD dwStatus;
+  HRESULT hRes, hRes2;

Can you implement this with a single variable instead?

@@ +576,3 @@
           &dwCurrentPlayCursor, NULL);

+      hRes2 =

e.g. here it should probably go out of the loop after the first error already

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.