[Bug 738292] hRes unckecked, which may cause a endless loop

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=738292
  GStreamer | gst-plugins-bad | 1.3.2

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #288213|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-10-14 08:22:07 UTC ---
Review of attachment 288213:
 --> (https://bugzilla.gnome.org/review?bug=738292&attachment=288213)

::: gstdirectsoundsrc.c
@@ +536,2 @@
   /* Starting capturing if not already */
+  if (SUCCEEDED (hRes) && !(dwStatus & DSCBSTATUS_CAPTURING)) {

I think if not succeeded it should return here already instead of going into
the loop below

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.