[Bug 738242] Segfault when trying to position a textoverlay outside of the video frame

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=738242
  GStreamer | gst-plugins-base | unspecified

--- Comment #10 from Vineeth <vineeth.tm at samsung.com> 2014-10-14 10:13:39 UTC ---
Created an attachment (id=288499)
 View: https://bugzilla.gnome.org/attachment.cgi?id=288499
 Review: https://bugzilla.gnome.org/review?bug=738242&attachment=288499

Patch

Hi Luis,
   The above patches still does not fix the crash properly.
   I am adding a patch which i think fixes all the crashes related to x and y
pos

   Added   
  *xpos = 0;
  *ypos = 0;
   Since setting ypos is added in else case, there are cases where ypos has a
junk value when the else condition is not satisfied. Hence initializing both
the values to 0 in the beginning.

 In Video-blend changes
"if (x + src_width > dest_width)"
 if this condition is satisfied, there is no way, dest_width will be >
src_width
which means the condition added in the previous patch is not useful.
 The better way is to set the *xpos and *ypos to 0, in case they lie outside
the video width and height, since anyways we are not going to show the same.

  Please check if they are valid.


Regards,
Vineeth

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.