[Bug 738575] New: matroskamux: Empty TAGS section if no valid MKV Tags are present

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=738575
  GStreamer | gst-plugins-good | 1.4.3

           Summary: matroskamux: Empty TAGS section if no valid MKV Tags
                    are present
    Classification: Platform
           Product: GStreamer
           Version: 1.4.3
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: clowd81 at gmail.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


In the matroskamux plugin, upon receiving an EOS it closes out the file,
writing various data, including a TAGS section.  The code to write this TAGS
section will write the header for the section to the file even if there are no
valid matroska tags in the tag list.  

This is because in matroska-mux.c, in the gst_matroska_mux_finish() function,
it checks to make sure tags != NULL, then writes the headers, then iterates
through the tag_list and attempts to write each tags to file.  However, the
code to write the tags - gst_matroska_mux_write_simple_tag() - will only write
15 specific tags to this section.  If none of those tags exist, the result is
an empty TAGS section with the headers indicating that there should be data
available.  This causes errors to be reported in several matroska validators.

A workaround is to use the following:

GstTagSetter *tagsetter = GST_TAG_SETTER(mux);
gst_tag_setter_reset_tags(tagsetter);

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.