[Bug 738845] audiomixer: critical error for blocksize, timeout min/max values

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon Oct 20 01:07:33 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=738845
  GStreamer | gst-plugins-bad | unspecified

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #288886|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-10-20 08:07:29 UTC ---
Review of attachment 288886:
 --> (https://bugzilla.gnome.org/review?bug=738845&attachment=288886)

::: gst-libs/gst/base/gstaggregator.c
@@ +1421,3 @@
           "Number of nanoseconds to wait for a buffer to arrive on a sink pad"
           "before the pad is deemed unresponsive (-1 unlimited)", -1,
+          G_MAXLONG * GST_SECOND - 1, DEFAULT_TIMEOUT,

This will overflow on 64 bit systems where long is 64 bits big. Just keep it as
is :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list