[Bug 738696] hlsdemux: send missing stream start

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=738696
  GStreamer | gst-plugins-bad | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #288766|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-10-20 10:45:30 UTC ---
Review of attachment 288766:
 --> (https://bugzilla.gnome.org/review?bug=738696&attachment=288766)

::: ext/hls/gsthlsdemux.c
@@ +269,3 @@
   demux->group_id = G_MAXUINT;
+
+  demux->need_stream_start = FALSE;

Shouldn't it be TRUE by default? Also reset to TRUE in the reset() function?

@@ +981,3 @@
+
+    gst_pad_push_event (demux->srcpad, event);
+    g_free (stream_id);

This code looks duplicated, refactor it into a helper function

@@ +2218,3 @@
+      demux->end_of_playlist = FALSE;
+      demux->discont = TRUE;
+      demux->need_stream_start = TRUE;

This seems weird. It should probably stay at end_of_playlist until a FLUSH or
reset happens... and after EOS no new stream-start event is needed usually.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.