[Bug 738526] vc1parse: implement some stream-format conversion

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon Oct 20 04:25:44 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=738526
  GStreamer | gst-plugins-bad | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #288515|none                        |needs-work
             status|                            |

--- Comment #10 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-10-20 11:25:37 UTC ---
Review of attachment 288515:
 --> (https://bugzilla.gnome.org/review?bug=738526&attachment=288515)

Something I also noticed in one of the other patches above

::: gst/videoparsers/gstvc1parse.c
@@ +1664,3 @@
+
+  new_buf = gst_byte_writer_reset_and_get_buffer (&bw);
+  ok &= gst_buffer_copy_into (new_buf, buffer, GST_BUFFER_COPY_METADATA, 0,
-1);

Instead of copying the complete buffer you can also just prepend the extra data
in front of the buffer as another GstMemory, while keeping the original
GstMemory untouched

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list