[Bug 727402] aiffmux: write padding byte at end of SSND chunk if needed

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=727402
  GStreamer | gst-plugins-bad | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #273357|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-10-20 11:40:11 UTC ---
Review of attachment 273357:
 --> (https://bugzilla.gnome.org/review?bug=727402&attachment=273357)

::: gst/aiff/aiffmux.c
@@ +141,3 @@
+  /* AIFF chunks must be even aligned */
+  cur_size = AIFF_HEADER_LEN - 8 + audio_data_size;
+  if (cur_size & 1 && ((cur_size + 1) < G_MAXUINT32)) {

No need for all these brackets, but I would make the & clearer

if ((cur_size & 1) && cur_size + 1 < G_MAXUINT32)

@@ +414,3 @@
+        GST_BUFFER_OFFSET (buffer) = AIFF_HEADER_LEN + aiffmux->length;
+        GST_BUFFER_OFFSET_END (buffer) = GST_BUFFER_OFFSET_NONE;
+        gst_pad_push (aiffmux->srcpad, buffer);

Check the return value and print debug output here

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.