[Bug 738285] playbin: Sequential playback of the file list does not work

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=738285
  GStreamer | gst-plugins-base | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #288921|none                        |needs-work
             status|                            |

--- Comment #12 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-10-20 12:13:12 UTC ---
Review of attachment 288921:
 --> (https://bugzilla.gnome.org/review?bug=738285&attachment=288921)

Thanks for updating the patch :)

::: gst/playback/gstdecodebin2.c
@@ +3787,3 @@
+    GST_OBJECT_LOCK (dbin);
+    while (!dbin->all_eos)
+      g_cond_wait (&dbin->all_eos_cond, GST_OBJECT_GET_LOCK (dbin));

This here needs to unlock on FLUSH_START events, and when going from PAUSED to
READY state (before chaining up to the parent class' change_state
implementation)

@@ +4781,3 @@
       DYN_UNLOCK (dbin);
       dbin->have_type = FALSE;
+      dbin->all_eos = FALSE;

The condition variable should probably also be reset on FLUSH_STOP

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.