[Bug 738285] playbin: Sequential playback of the file list does not work

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=738285
  GStreamer | gst-plugins-base | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #289005|none                        |needs-work
             status|                            |

--- Comment #15 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-10-21 09:01:22 UTC ---
Review of attachment 289005:
 --> (https://bugzilla.gnome.org/review?bug=738285&attachment=289005)

::: gst/playback/gstdecodebin2.c
@@ +3754,2 @@
     g_signal_emit (dbin, gst_decode_bin_signals[SIGNAL_DRAINED], 0, NULL);
+    DYN_LOCK (dbin);

Why do you switch to the DYN_LOCK from the OBJECT_LOCK?

@@ +4515,3 @@
+    case GST_EVENT_FLUSH_STOP:
+      DYN_LOCK (dbin);
+      dbin->flushing = FALSE;

Flushing is per pad, not globally

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.