[Bug 738416] decodebin: Fix autoplugging of parser elements

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=738416
  GStreamer | gst-plugins-base | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #288985|none                        |needs-work
             status|                            |

--- Comment #12 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-10-21 09:07:52 UTC ---
Review of attachment 288985:
 --> (https://bugzilla.gnome.org/review?bug=738416&attachment=288985)

I think in general it's enough to test if the previous element is also a
parser, checking the media type seems not needed. It's not like some parser is
going to convert audio to video or otherwise change the media type in such a
way.

::: gst/playback/gstdecodebin2.c
@@ +2135,3 @@
+
+        is_video_parser =
+            strstr (classification, "Video") != NULL ? TRUE : FALSE;

For video we also use "Image" in some places

@@ +2141,3 @@
+        if (!is_video_parser && !is_audio_parser)
+          is_subtitle_parser =
+              strstr (classification, "Subtitle") != NULL ? TRUE : FALSE;

And for subtitles there's also "SubPicture"

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.