[Bug 738984] New: basetextoverlay: segfault for min/max values of element properties

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=738984
  GStreamer | gst-plugins-base | unspecified

           Summary: basetextoverlay: segfault for min/max values of
                    element properties
    Classification: Platform
           Product: GStreamer
           Version: unspecified
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-base
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: vineeth.tm at samsung.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Created an attachment (id=289101)
 View: https://bugzilla.gnome.org/attachment.cgi?id=289101
 Review: https://bugzilla.gnome.org/review?bug=738984&attachment=289101

proposed patch

In basetextoverlay added
*ypos = 0;
   Since setting ypos is added in else case, there are cases where ypos has a
junk value when the else condition is not satisfied. Hence initializing the
value to 0 in the beginning.

 In Video-blend changes
Right now the condition is like this
   if (x + src_width > dest_width)
     if (dest_width > x)
       src_width = dest_width - x;
   But with this chances are there when src_width will not be re-calculated and
it will be more that the width of the video, which results in segfault.
 The better way is to set the *xpos and *ypos to 0 in basetextoverlay, in case
they lie outside the video width and height, since anyways we are not going to
show the same.

  Please check if they are valid.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.