[Bug 738984] basetextoverlay: segfault for min/max values of element properties

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=738984
  GStreamer | gst-plugins-base | unspecified

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #289101|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-10-23 08:29:45 UTC ---
Review of attachment 289101:
 --> (https://bugzilla.gnome.org/review?bug=738984&attachment=289101)

::: gst-libs/gst/video/video-blend.c
@@ -331,3 @@
   if (y + src_height > dest_height)
-    if (dest_height > y)
-      src_height = dest_height - y;

Can't this become negative now?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.