[Bug 738285] playbin: Sequential playback of the file list does not work

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=738285
  GStreamer | gst-plugins-base | git

--- Comment #54 from Andrei Sarakeev <sarakusha at gmail.com> 2014-10-24 08:11:50 UTC ---
Review of attachment 289248:
 --> (https://bugzilla.gnome.org/review?bug=738285&attachment=289248)

::: gst/playback/gstdecodebin2.c
@@ +3678,3 @@
+    CHAIN_MUTEX_LOCK (chain);
+    chain->drained = TRUE;
+    chain->endpad->drained = TRUE;

If not linked stream longer then active, it will not be drained. In the future,
if it will come the data we discard them.

@@ +3682,3 @@
+    peer = gst_pad_get_peer (GST_PAD_CAST (chain->endpad));
+    if (peer) {
+    CHAIN_MUTEX_LOCK (chain);

endpad is source pad, not sink pad. EOS is downstream event.

@@ +3722,2 @@
     chain->drained = chain->endpad->drained;
+    *drained = chain->endpad->notlinked;

drained state not saved in the pad (chain->endpad->drained != TRUE), only now

@@ +3801,3 @@
   }
+  // return last_group;
+  return FALSE;

Ok

@@ +4645,3 @@
+  if (drained) {
+    gst_buffer_unref (buffer);
+  gboolean drained;

if not-linked stream longer then active and we already drained signal emit

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.