[Bug 738248] wavparse should read the Broadcast Wave Format (BWF)

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=738248
  GStreamer | gst-plugins-good | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #288152|none                        |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-10-26 11:10:42 UTC ---
Review of attachment 288152:
 --> (https://bugzilla.gnome.org/review?bug=738248&attachment=288152)

::: gst/wavparse/gstwavparse.c
@@ +220,3 @@
+      "BWF/TimeReference", "Broadcast Wave Format: Time reference", NULL);
+  gst_tag_register (BWF_TAG_VERSION, GST_TAG_FLAG_META, G_TYPE_INT,
+      "BWF/Version", "Broadcast Wave Format: Version", NULL);

Maybe some of the tags can be mapped to already existing tags?

@@ +1098,3 @@
+  gst_buffer_map (buf, &map, GST_MAP_READ);
+
+  memcpy (txt, map.data, 256);

You should check here that actually enough data is available before blindly
parsing it.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.