[Bug 737708] pngdec: change parse logic

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon Oct 27 19:54:51 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=737708
  GStreamer | gst-plugins-good | unspecified

--- Comment #9 from Vineeth <vineeth.tm at samsung.com> 2014-10-28 02:54:47 UTC ---
Hi Luis,


Thanks for the review.

I am using a simple pipeline to test the same

gst-launch-1.0 filesrc location=../media/icon.png ! pngdec ! videoconvert !
ximagesink


And the value 12 is because of below

    if (!gst_byte_reader_get_uint32_be (&reader, &length))
      goto need_more_data;
    if (!gst_byte_reader_get_uint32_le (&reader, &code))
      goto need_more_data;
    if (!gst_byte_reader_skip (&reader, length + 4))
      goto need_more_data;

4 for uint32_be, 4 for uint32_le and length + 4 for skip

so total of length + 12

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list