[Bug 739281] video-blend: correct improper logic calculations
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Tue Oct 28 03:57:02 PDT 2014
https://bugzilla.gnome.org/show_bug.cgi?id=739281
GStreamer | gst-plugins-base | unspecified
--- Comment #5 from Vineeth <vineeth.tm at samsung.com> 2014-10-28 10:56:57 UTC ---
yes textoverlay is not the only user..
but whoever uses video-blend should take care of this.
as any value of x/y < 0 and x/y > image_width/height is invalid and should be
reset to 0.
in case any other user of video-blend does not set this..
let us say x is being sent as -2000
now as per the calculation src_width will be width of text, which will be
around 61 for "text" - 2000, will become 61 - 2000 = -1939 which is an invalid
value
hence the calculation is wrong.
another option to fix this will be(in case the users of video-blend does not
take care of resetting to 0)
if(x < 0 && x > dest_width)
x = 0;
if(y < 0 && y > dest_height)
y = 0;
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list