[Bug 738033] mpegts : add new descriptors and cleanup
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Tue Oct 28 06:12:20 PDT 2014
https://bugzilla.gnome.org/show_bug.cgi?id=738033
GStreamer | gst-plugins-bad | 1.4.3
--- Comment #20 from Edward Hervey <bilboed at bilboed.com> 2014-10-28 13:12:16 UTC ---
A few comments:
* Please put your email address (alongside your name) in the headers
* Some of this code was just moved from other files, please include the
original authors in the headers
* For the new descriptor parsing you've added, could you also add the
corresponding support in tests/examples/mpegts/ ? This helps to make sure the
API is correct.
* The various API addition need to be added to the docs (docs/libs/)
The enum addition/movement are fine (once licenses are updated), I'll push them
once you've updated those.
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list