[Bug 731769] add element implementing the ONVIF RTP extension

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=731769
  GStreamer | gst-plugins-bad | unspecified

--- Comment #10 from Olivier Crete (Tester) <olivier.crete at ocrete.ca> 2014-10-28 19:30:52 UTC ---
Review of attachment 289474:
 --> (https://bugzilla.gnome.org/review?bug=731769&attachment=289474)

::: gst/onvif/gstrtponviftimestamp.c
@@ +161,3 @@
+      g_param_spec_uint64 ("ntp-offset", "NTP offset",
+          "Offset between the pipeline running time and the absolute UTC time,
"
+          "in seconds since 1900",

Instead of having the app set this, if, on the paused->playing, we could just
do a gettimeofday()+gst_clock_get_time(), and that as a base time for the
translation to NTP time?

@@ +302,3 @@
+
+  /* NTP timestamp */
+  if (GST_BUFFER_DTS_IS_VALID (buf)) {

Shouldn't it use PTS as a first attempt ?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.