[Bug 739345] codecparsers: remove ignored increment of return
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Wed Oct 29 08:10:46 PDT 2014
https://bugzilla.gnome.org/show_bug.cgi?id=739345
GStreamer | gst-plugins-bad | git
--- Comment #6 from Luis de Bethencourt <luis.bg at samsung.com> 2014-10-29 15:10:41 UTC ---
Created an attachment (id=289595)
View: https://bugzilla.gnome.org/attachment.cgi?id=289595
Review: https://bugzilla.gnome.org/review?bug=739345&attachment=289595
Do the increment correctly and clean the code
The problem was that the code was adding 1 just before the only usage of
markersize.
> if (gst_bit_reader_get_bits_uint32_unchecked (&br, markersize + 1) != 0x01)
So to make this cleaner I brought the increment back, but as a pre-increment
and removed the + 1 in the above line.
Also, the variable markersize doesn't need to be stored in the GstMpeg4Packet
structure since the above is the only function block that uses it. So I removed
that and cleaned it.
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list