[Bug 739345] codecparsers: remove ignored increment of return

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=739345
  GStreamer | gst-plugins-bad | git

--- Comment #8 from Luis de Bethencourt <luis.bg at samsung.com> 2014-10-29 17:45:15 UTC ---
Hahahahahaha... that code never actually runs

gst-libs/gst/codecparsers/gstmpeg4parser.c:424
> GstMpeg4ParseResult
> gst_mpeg4_parse (GstMpeg4Packet * packet, gboolean skip_user_data,
>     GstMpeg4VideoObjectPlane * vop, const guint8 * data, guint offset,
>     gsize size)
> {

Every single instance that calls that function in the actual code passes NULL
for the vop object parameter.
and then:
>   if (vop) {
>     resync_res =
>         gst_mpeg4_next_resync (packet, vop, data + offset, size - offset,
>         first_resync_marker);

gst_mpeg4_next_resync, which only runs if vop is !NULL (which never is) is the
usage of compute_resync_marker_size() that actually uses the returned value.

This is nice to have implemented, but as it stands, nobody ever uses it.

Looking at the bitstream it looks ++off was the intended thing since the
returned value off is the equivalent of "space until the next marker, and one
more to be *AT* the beginning of the next packet". But nobody ever catched the
bug because it never runs :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.