[Bug 712343] riff: Make use of the various helper to handle video formats

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=712343
  GStreamer | gst-plugins-base | unspecified

Thibault Saunier <tsaunier> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #259844|0                           |1
        is obsolete|                            |

--- Comment #4 from Thibault Saunier <tsaunier at gnome.org> 2014-10-30 13:00:59 UTC ---
Created an attachment (id=289662)
 View: https://bugzilla.gnome.org/attachment.cgi?id=289662
 Review: https://bugzilla.gnome.org/review?bug=712343&attachment=289662

> ::: gst-libs/gst/riff/riff-media.c

> @@ +82,3 @@
> +            break;
> +          case 16:
> +            format = GST_VIDEO_FORMAT_RGB16;
> 
> Are 15 and 16 valid here? I don't see them in the old code.

Indeed it was not in the old code, removed

> @@ +85,3 @@
> +            break;
> +          case 24:
> +            format = GST_VIDEO_FORMAT_RGB;
> 
> This was BGR, not RGB

My mistake, FIXED

> @@ +88,3 @@
> +            break;
> +          case 32:
> +            format = GST_VIDEO_FORMAT_ARGB;
> 
> This should be BGRx, not ARGV

My mistake, FIXED

> @@ -900,3 @@
>        caps = gst_caps_new_empty_simple ("video/x-fraps");
> -      if (codec_name)
> -        *codec_name = g_strdup ("Fraps video");

> This isn't in pbutils, neither is x-xsub, we shoudl go over the entire list
> first before we remove them. Either we should add it there or leave this here.

I added them in pbutils and went over the whole list adding the other missing
ones

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.