[Bug 739351] baseparse: parser fixed caps flag issue

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=739351
  GStreamer | gstreamer (core) | 1.4.3

Aurélien Zanelli <aurelien.zanelli> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aurelien.zanelli at parrot.com

--- Comment #3 from Aurélien Zanelli <aurelien.zanelli at parrot.com> 2014-10-31 16:32:35 UTC ---
Correct me if I'm wrong, but since this flag is set in many base class, I'm not
sure it's the right way to fix the issue.

Assumimg querying the src pad peer caps will not result in the current
negotiated caps, we may do something like this:

diff --git a/gst/audioparsers/gstaacparse.c b/gst/audioparsers/gstaacparse.c
index aee1248..8fe929b 100644
--- a/gst/audioparsers/gstaacparse.c
+++ b/gst/audioparsers/gstaacparse.c
@@ -214,7 +214,7 @@ gst_aac_parse_set_src_caps (GstAacParse * aacparse, GstCaps
* sink_caps)
   if (stream_format)
     gst_structure_set (s, "stream-format", G_TYPE_STRING, stream_format,
NULL);

-  allowed = gst_pad_get_allowed_caps (GST_BASE_PARSE (aacparse)->srcpad);
+  allowed = gst_pad_peer_query_caps (GST_BASE_PARSE (aacparse)->srcpad, NULL);
   if (!gst_caps_can_intersect (src_caps, allowed)) {
     GST_DEBUG_OBJECT (GST_BASE_PARSE (aacparse)->srcpad,
         "Caps can not intersect");

I didn't make a patch because I'm not sure it's right either and I didn't test
it.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.