[Bug 735795] New: imagefreeze: missing gst_caps_unref

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=735795
  GStreamer | gst-plugins-good | unspecified

           Summary: imagefreeze: missing gst_caps_unref
    Classification: Platform
           Product: GStreamer
           Version: unspecified
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: vineeth.tm at samsung.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


On reviewing imagefreeze element, found some possible inconsistencies
i have made three changes in this patch,
1) gst_caps_unref (filter) is not being called when 
 if (gst_pad_has_current_caps (pad)) satisfies in
gst_image_freeze_sink_getcaps()

2) replacing gst_caps_make_writable (gst_caps_ref (caps)) with 
 gst_caps_copy (caps) in line 177, since the functionality is same.

3) in function, gst_image_freeze_sink_getcaps(), when the below else case is
executed,
  ...
  } else {
    GST_LOG_OBJECT (self, "going to copy");
    ret = gst_caps_copy (templ);
  }
  ...

  templ will already be unreferenced by gst_caps_copy, hence adding a check as
below

  if (templ)
    gst_caps_unref (templ);

Please review and check if the changes are fine.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.