[Bug 735795] imagefreeze: missing gst_caps_unref

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=735795
  GStreamer | gst-plugins-good | unspecified

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #284982|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-09-01 09:02:46 UTC ---
Review of attachment 284982:
 --> (https://bugzilla.gnome.org/review?bug=735795&attachment=284982)

::: gst/imagefreeze/gstimagefreeze.c
@@ +270,3 @@
     ret = gst_pad_get_current_caps (pad);
+    if (filter)
+      gst_caps_unref (filter);

This is wrong, we don't own a reference to filter at this point. Only after the
gst_caps_copy() call. Here it's still only owned by the caller

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.